Remove PHP 7.1 from CI#3572
Conversation
alanpoulain
commented
May 18, 2020
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tickets | N/A |
| License | MIT |
| Doc PR | N/A |
|
@dunglas could you remove 7.1 from required status check please? |
|
But why? We still support PHP 7.1 isn't it? |
|
We still support it, but it causes test issues because of the new Doctrine Inflector (BC changes and PHP > 7.1). |
|
Can't we add a BC layer to support older versions of Doctrine Inflector? Or aren't these versions maintained? That being said, OK for me to trop support for PHP 7.1 in 2.6, but we should keep the tests for 2.5. Btw, at some point I would like to switch from Doctrine Inflector to Symfony String). |
|
Yes, we can add a BC layer (that's what it has been done here: #3564). |
|
let's rebase this onto master, wdyt @alanpoulain ? |
Why @dunglas? |
|
To prevent this kind of issues. |